Fix: geometry-lab angle/pan now repaint the panels#12
Merged
Conversation
The render effect read gammaRad / experiment.panU / experiment.panV only inside its requestAnimationFrame callback. Svelte 5 tracks dependencies read synchronously during the effect run, not ones read later in an async callback, so changing the angle or panning never re-triggered a render — only the axes overlay (a $derived used directly in the template) updated. Symptoms: pan did nothing; the rotation slider moved only the dashed axis line while the rotated- log image stayed put. Read rot / kTwist / panU / panV synchronously in the effect body so they're tracked; the rAF callback now closes over those locals. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: in the pipeline geometry lab, panning the rotated-log did nothing, and the rotation slider moved only the dashed axis line — the rotated-log image stayed put.
Cause: the render
$effectreadgammaRad/experiment.panU/experiment.panVonly inside itsrequestAnimationFramecallback. Svelte 5 tracks dependencies read synchronously during the effect, not in a later async callback, so angle/pan changes never re-triggered a render. The axes overlay updated because it's a separate$derivedused in the template.Fix: read
rot/kTwist/panU/panVsynchronously in the effect body; the rAF callback closes over those locals.Verified in-browser: angle now rotates the rotated-log image; dragging it rotates+zooms the tententoon. Tests 22/22, check clean.
🤖 Generated with Claude Code